Update jruby-openssl to 0.16.0#19114
Merged
Merged
Conversation
Take up the latest jruby-openssl in 8.19.
Contributor
🤖 GitHub commentsJust comment with:
|
donoghuc
commented
May 14, 2026
| gem.add_runtime_dependency 'ruby-maven-libs', '~> 3', '>= 3.8.9' | ||
| gem.add_runtime_dependency "jar-dependencies",'= 0.4.1' # Pin to `0.4.1` until https://github.com/jruby/jruby/issues/7262 is resolved | ||
| gem.add_runtime_dependency "jruby-openssl", "~> 0.15.4" # Pin until upgrade to jruby 9.4.12.0 https://github.com/elastic/logstash/issues/17007 | ||
| gem.add_runtime_dependency "jruby-openssl", "~> 0.16.0" |
Member
Author
There was a problem hiding this comment.
I'm struggling to find why this pin was necssary. #17650 i suppose it would be best to delete this line all together if I cant spot it.
Member
Author
|
run exhaustive tests |
💚 Build Succeeded
|
donoghuc
commented
May 14, 2026
| gem.add_runtime_dependency 'ruby-maven-libs', '~> 3', '>= 3.8.9' | ||
| gem.add_runtime_dependency "jar-dependencies",'= 0.4.1' # Pin to `0.4.1` until https://github.com/jruby/jruby/issues/7262 is resolved | ||
| gem.add_runtime_dependency "jruby-openssl", "~> 0.15.4" # Pin until upgrade to jruby 9.4.12.0 https://github.com/elastic/logstash/issues/17007 | ||
| gem.add_runtime_dependency "jruby-openssl", "~> 0.16.0" |
Member
Author
There was a problem hiding this comment.
Suggested change
| gem.add_runtime_dependency "jruby-openssl", "~> 0.16.0" |
Member
Author
There was a problem hiding this comment.
I'm not sure why this was added. PR and exhaustive tests pass. I think removal (to match upstream) is appropriate. LMK if there is something i've missed.
Member
Author
There was a problem hiding this comment.
I"m going to do this in a follow up PR as I want to get this in for FF today and i want to vet this more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
Update
jruby-opensslto 0.16.0.What does this PR do?
Take up the latest jruby-openssl in 8.19.