Skip to content

Bump jackson and jrjackson dependencies - #19249

Merged
donoghuc merged 4 commits into
elastic:mainfrom
donoghuc:bump-jackson
Jul 9, 2026
Merged

Bump jackson and jrjackson dependencies#19249
donoghuc merged 4 commits into
elastic:mainfrom
donoghuc:bump-jackson

Conversation

@donoghuc

Copy link
Copy Markdown
Member

Release notes

Update jackson-databind to 2.21.4

What does this PR do?

Updates jackson dep stack to latest patched version.

NOTE:

Depends on guyboertje/jrjackson#101 and a release there.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

Comment thread versions.yml Outdated
jrjackson: 0.5.0
jackson: 2.21.2
jackson-databind: 2.21.2
jrjackson: 0.5.0.1

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unreleased guyboertje/jrjackson#101 Might change to 0.5.1...

@github-actions

This comment has been minimized.

Comment thread versions.yml
jackson-databind: 2.21.2
jrjackson: 0.5.0.1
jackson: 2.21.4
jackson-databind: 2.21.4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
I remember the versions are reflected in notice.txt file -

Notice for: com.fasterxml.jackson.core:jackson-databind-2.21.2

Can you also please update?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. yep. updated. once the jrjackson version number is finalized i'll update it.

@github-actions

This comment has been minimized.

@donoghuc
donoghuc marked this pull request as ready for review July 7, 2026 17:32
@donoghuc

donoghuc commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

run exhaustive tests

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

TL;DR

The current Buildkite failures are caused by the newly-pinned jrjackson 0.5.1 gem loading incorrectly: require "logstash/json" fails because jrjackson-0.5.1-java/lib/jrjackson/jrjackson.rb requires jrjackson_jars, but the installed gem does not include lib/jrjackson_jars.rb. This is different from the earlier 0.5.0.1 unavailable-gem failure; 0.5.1 resolves, but cannot load.

Remediation

  • Fix/re-release the upstream jrjackson 0.5.1 Java gem so it includes the generated lib/jrjackson_jars.rb loader expected by lib/jrjackson/jrjackson.rb:6, or temporarily pin Logstash back to a loadable jrjackson version.
  • After the gem is fixed or the pin is changed, rerun ./gradlew --no-daemon :logstash-xpack:rubyTests --tests org.logstash.xpack.test.RSpecTests and the x-pack integration step.
Investigation details

Root Cause

This PR pins jrjackson: 0.5.1 in versions.yml:30, and logstash-core/logstash-core.gemspec:79 consumes it as an exact runtime dependency:

gem.add_runtime_dependency "jrjackson", "= #{ALL_VERSIONS.fetch('jrjackson')}" #(Apache 2.0 license)

With that gem installed, Logstash's JSON wrapper loads jrjackson from logstash-core/lib/logstash/json.rb:19. The gem then fails at vendor/bundle/jruby/3.4.0/gems/jrjackson-0.5.1-java/lib/jrjackson/jrjackson.rb:6:

require "jrjackson_jars"

The installed jrjackson-0.5.1-java gem contains the Jackson jars and lib/jrjackson/jars/jrjackson-1.3.0.jar, but does not contain the required lib/jrjackson_jars.rb file, so every x-pack spec that loads logstash/devutils/rspec/spec_helper or logstash/agent fails during file load before examples run.

Evidence

0 examples, 0 failures, 19 errors occurred outside of examples
...
Execution failed for task ':logstash-xpack:rubyTests'.
> There were failing tests.
0 examples, 0 failures, 12 errors occurred outside of examples
...
Execution failed for task ':logstash-xpack:rubyIntegrationTests'.
> There were failing tests.

Local reproduction on commit eaad695e4931610b9eb293fe8e2431d69d721202 produced the missing loader error:

LoadError: cannot load such file -- jrjackson_jars
  <main> at .../vendor/bundle/jruby/3.4.0/gems/jrjackson-0.5.1-java/lib/jrjackson/jrjackson.rb:6
  <main> at .../vendor/bundle/jruby/3.4.0/gems/jrjackson-0.5.1-java/lib/jrjackson.rb:2
  <main> at .../logstash-core/lib/logstash/json.rb:19

Verification

  • GRADLE_USER_HOME=/tmp/gh-aw/agent/gradle-home ./gradlew --no-daemon bootstrap succeeds, confirming the old unresolved-gem blocker is gone for 0.5.1.
  • GRADLE_USER_HOME=/tmp/gh-aw/agent/gradle-home ./gradlew --no-daemon :logstash-xpack:rubyTests --tests org.logstash.xpack.test.RSpecTests --stacktrace reproduces the x-pack failure locally with LoadError: cannot load such file -- jrjackson_jars.
  • bin/ruby -Ilogstash-core/lib -e 'require "logstash/json"; puts LogStash::Json.dump({"ok"=>true})' reproduces the same minimal load failure.
  • Checked the installed gem contents and confirmed vendor/bundle/jruby/3.4.0/gems/jrjackson-0.5.1-java/lib/jrjackson_jars.rb is absent.

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@donoghuc

donoghuc commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

Filed guyboertje/jrjackson#102 to address the missing file in 0.5.1 gem

@donoghuc

donoghuc commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

run exhaustive tests

@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

History

@donoghuc
donoghuc merged commit bb92531 into elastic:main Jul 9, 2026
12 checks passed
@donoghuc

donoghuc commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport 9.4

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

backport 9.4

✅ Backports have been created

Details

@donoghuc

donoghuc commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport 9.5

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

backport 9.5

✅ Backports have been created

Details

donoghuc added a commit that referenced this pull request Jul 9, 2026
* Bump jackson and jrjackson dependencies

* Update jackson and jrjackson versions in NOTICE.TXT

* finalized version

* take up 0.5.2

(cherry picked from commit bb92531)
@donoghuc

donoghuc commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport 9.3, 8.19

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

backport 9.3, 8.19

❌ No backport have been created

Details
  • Backport to branch 9.3, failed

GitHub error: Branch not found

Cherry-pick of bb92531 has failed:

On branch mergify/bp/8.19/pr-19249
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit bb92531e3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   versions.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.TXT

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@donoghuc

donoghuc commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio backport 9.3

@mergify

mergify Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

backport 9.3

✅ Backports have been created

Details

Cherry-pick of bb92531 has failed:

On branch mergify/bp/9.3/pr-19249
Your branch is up to date with 'origin/9.3'.

You are currently cherry-picking commit bb92531e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   versions.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   NOTICE.TXT

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

donoghuc added a commit that referenced this pull request Jul 9, 2026
* Bump jackson and jrjackson dependencies (#19249)

* Bump jackson and jrjackson dependencies

* Update jackson and jrjackson versions in NOTICE.TXT

* finalized version

* take up 0.5.2

(cherry picked from commit bb92531)

* update lockfile

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Jul 9, 2026
* Bump jackson and jrjackson dependencies (#19249)

* Bump jackson and jrjackson dependencies

* Update jackson and jrjackson versions in NOTICE.TXT

* finalized version

* take up 0.5.2

(cherry picked from commit bb92531)

* update lockfile

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Jul 9, 2026
)

* Bump jackson and jrjackson dependencies (#19249)

* Bump jackson and jrjackson dependencies

* Update jackson and jrjackson versions in NOTICE.TXT

* finalized version

* take up 0.5.2

(cherry picked from commit bb92531)

# Conflicts:
#	NOTICE.TXT

* fix mergeconflict and update lockfile

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Jul 9, 2026
* Bump jackson and jrjackson dependencies (#19249)

* Bump jackson and jrjackson dependencies

* Update jackson and jrjackson versions in NOTICE.TXT

* finalized version

* take up 0.5.2

(cherry picked from commit bb92531)

# Conflicts:
#	NOTICE.TXT

* fix mergeconflict and update lockfile

---------

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants