fix(s2): fix unescaped Python strings — proper tests#216
Merged
Conversation
elazarcoh
force-pushed
the
fix/s2-unescaped-python-strings
branch
from
8166f48 to
955b028
Compare
An error occurred while trying to automatically change base from
ci/vitest-framework
to
main
March 7, 2026 21:32
elazarcoh
force-pushed
the
fix/s2-unescaped-python-strings
branch
from
955b028 to
6100ba5
Compare
elazarcoh
force-pushed
the
fix/s2-unescaped-python-strings
branch
from
6100ba5 to
7713587
Compare
✅ CI Results🧪 Tests
📦 Artifactsscreenshots-ubuntu-latest · test-results · extension-vsix · ts-unit-test-results · python-unit-test-results |
asPythonValue() wraps strings in single quotes without escaping backslashes or quotes. A string containing a single quote (e.g., from a file path or user expression) would produce invalid Python or allow unintended code execution in the eval'd code. Fix: escape backslashes first, then single quotes, before wrapping in Python string literal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ode source Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
elazarcoh
force-pushed
the
fix/s2-unescaped-python-strings
branch
from
7713587 to
b0d56d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on ci/vitest-framework. Export asPythonValue. Replaced hand-rolled JS test with vitest as-python-value.test.ts importing real BuildPythonCode. Tests verify correct escaping of single quotes and backslashes.