fix(r3): fix chunk map memory leak — proper tests#219
Open
fix(r3): fix chunk map memory leak — proper tests#219
Conversation
elazarcoh
force-pushed
the
fix/r3-memory-leak-chunks
branch
from
9085466 to
41fddad
Compare
An error occurred while trying to automatically change base from
ci/vitest-framework
to
main
March 7, 2026 21:32
elazarcoh
force-pushed
the
fix/r3-memory-leak-chunks
branch
from
41fddad to
a2fd0fe
Compare
elazarcoh
force-pushed
the
fix/r3-memory-leak-chunks
branch
from
a2fd0fe to
ce042cd
Compare
✅ CI Results🧪 Tests
📦 Artifactsscreenshots-ubuntu-latest · test-results · extension-vsix · ts-unit-test-results · python-unit-test-results |
elazarcoh
force-pushed
the
fix/r3-memory-leak-chunks
branch
from
ce042cd to
e278457
Compare
Completed message chunks were never removed from the chunksByMessageId Map, causing unbounded memory growth during long debug sessions. Each image/tensor transfer left an orphaned entry. Fix: delete the map entry immediately after extracting the full message and before calling handleMessage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…integration tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…euse to stress test Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ediate race in tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
elazarcoh
force-pushed
the
fix/r3-memory-leak-chunks
branch
from
c92ba48 to
cea6906
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on ci/vitest-framework. Added pendingChunkCount getter to Server.ts for observability. Integration tests verify map cleanup after message reassembly.