fix: quote column names in json_to_recordset AS clause#954
Open
alexspeller wants to merge 1 commit intoelectric-sql:mainfrom
Open
fix: quote column names in json_to_recordset AS clause#954alexspeller wants to merge 1 commit intoelectric-sql:mainfrom
alexspeller wants to merge 1 commit intoelectric-sql:mainfrom
Conversation
Column names in the json_to_recordset AS clause were unquoted, causing PostgreSQL to lowercase them. This meant camelCase JSON keys didn't match the lowercased column names, producing NULLs. The insert and csv/COPY methods already properly double-quote column names; this aligns the json method with them.
alexspeller
force-pushed
the
fix/json-insert-quote-column-names
branch
from
e98ce80 to
bf640ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json_to_recordsetAS clause were unquoted, so PostgreSQL lowercased them. CamelCase JSON keys (e.g.firstName) didn't match the lowercased column names (e.g.firstname), producing NULLs.insertandcsv/COPY methods already properly double-quote column names — this aligns thejsonmethod with them.Test plan
"firstName","lastName") usinginitialInsertMethod: 'json'pglite-synctest suite passes (17/17)