fix: frameless windows do not shrink after constraints are applied on Windows#51499
Open
mitchchn wants to merge 2 commits intoelectron:mainfrom
Open
fix: frameless windows do not shrink after constraints are applied on Windows#51499mitchchn wants to merge 2 commits intoelectron:mainfrom
mitchchn wants to merge 2 commits intoelectron:mainfrom
Conversation
mitchchn
force-pushed
the
external-resize-handle-constraint-followups
branch
from
15ad1ae to
a4bf808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #51465.
I am backporting a Chromium CL to handle insets more consistently which I expect to be merged soon: https://chromium-review.googlesource.com/c/chromium/src/+/7795073.
That CL will also replace an older patch, which I removed.
(Reopened from #51498 — the previous PR was closed automatically when the source branch was renamed to fix a typo.)
For 41.x, 42.x
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where frameless windows windows could shrink after applying constraints or toggling resizability on Windows.