Make pinned action a property action #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Nov 26, 2025
| action_group.add_action (new PropertyAction (PINNED_ACTION, app, "pinned")); | ||
| insert_action_group (ACTION_GROUP_PREFIX, action_group); | ||
|
|
||
| insert_action_group (App.ACTION_GROUP_PREFIX, app.app_action_group); |
Member
There was a problem hiding this comment.
I kinda don't like renaming the action group in App because it looks like this when used elsewhere. I think app.action_group was cleaner
danirabbit
reviewed
Nov 26, 2025
danirabbit
reviewed
Nov 26, 2025
danirabbit
approved these changes
Nov 26, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I didn't think about the circular reference. I personally like this less in terms of organization but it fixes the issue for me, so happy to approve it! Thanks for investigating!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
Menu and actions are UI stuff and not model stuff so move the pinned action and the main menu model to launcher. Make the pinned action a property action there. PropertyAction keeps a reference on the object whose property it represents so it shouldnt be in the same class because that would form a reference cycle. Also using property action means the property has to be public set anyways so IMO the property action should be created by its consumer which is in this case the launcher (the app shouldn't have to care about how pinned is set).
Closes #508