Skip to content

AppChooser/Dialog: handle links - #171

Merged
danirabbit merged 3 commits into
mainfrom
danirabbit/appchooser-handlelinks
Jan 30, 2026
Merged

AppChooser/Dialog: handle links#171
danirabbit merged 3 commits into
mainfrom
danirabbit/appchooser-handlelinks

Conversation

@danirabbit

Copy link
Copy Markdown
Member
  • This portal also handles opening links, so get rid of defaults that assume a file
  • Give a user-readable content type if the content type is a link
  • Check that we have an icon for the content type before assigning it

AFTER

Screenshot from 2026-01-29 09 15 52

BEFORE

Screenshot from 2026-01-29 09 18 20

@danirabbit
danirabbit requested a review from a team January 29, 2026 17:19
@danirabbit
danirabbit requested a review from a team January 29, 2026 18:27

@lenemter lenemter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header and secondary text are swapped in your screenshot but otherwise looks good to me!

image

@danirabbit

Copy link
Copy Markdown
Member Author

We switched it in another branch. Thanks!

@danirabbit
danirabbit merged commit ec29931 into main Jan 30, 2026
4 checks passed
@danirabbit
danirabbit deleted the danirabbit/appchooser-handlelinks branch January 30, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants