Skip to content

PortalDialog: make button construction internal - #177

Merged
danirabbit merged 4 commits into
mainfrom
danirabbit/portaldialog-buttons
Feb 12, 2026
Merged

PortalDialog: make button construction internal#177
danirabbit merged 4 commits into
mainfrom
danirabbit/portaldialog-buttons

Conversation

@danirabbit

@danirabbit danirabbit commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Makes all the button construction internal. We only ever have two buttons, so we can handle it in PortalDialog
  • Changes "Cancel" to a more assertive "Don't Allow"

@danirabbit
danirabbit force-pushed the danirabbit/portaldialog-buttons branch from dd97988 to 09a7ccc Compare February 8, 2026 17:25
@danirabbit
danirabbit requested review from a team and wpkelso February 8, 2026 17:25
@danirabbit
danirabbit marked this pull request as ready for review February 8, 2026 17:25
@danirabbit
danirabbit enabled auto-merge (squash) February 12, 2026 19:39
@danirabbit
danirabbit merged commit 43fab1d into main Feb 12, 2026
4 checks passed
@danirabbit
danirabbit deleted the danirabbit/portaldialog-buttons branch February 12, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardo-lemos leonardo-lemos leonardo-lemos approved these changes
+1 more reviewer
@wpkelso wpkelso wpkelso approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @leonardo-lemos @wpkelso