Skip to content

Session: don't destroy dialog before setup recording - #183

Merged
danirabbit merged 1 commit into
mainfrom
danirabbit/screencast-deletebeforeuse
Mar 18, 2026
Merged

Session: don't destroy dialog before setup recording#183
danirabbit merged 1 commit into
mainfrom
danirabbit/screencast-deletebeforeuse

Conversation

@danirabbit

Copy link
Copy Markdown
Member

Fixes #182

  • Make sure we don't destroy the dialog before setting up recording
  • Data as function args not UI
  • destroy not close since we don't want to send DELETE_EVENT

@danirabbit
danirabbit requested a review from a team March 9, 2026 18:17
@danirabbit danirabbit added this to OS 9 Mar 16, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Mar 16, 2026
@danirabbit
danirabbit merged commit df7982a into main Mar 18, 2026
3 of 4 checks passed
@danirabbit
danirabbit deleted the danirabbit/screencast-deletebeforeuse branch March 18, 2026 14:23
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Screen sharing stopped working on Wayland; xdg-desktop-portal-pantheon crashes after selecting a monitor

2 participants