fix(types): Mark all nested types from experimental payloads as @experimental - #903
Merged
Merged
Conversation
…rimental Changed generator to mark ALL types generated from an experimental payload, not just the root type. This ensures ReasoningResponsePart and ReasoningResponsePartType are also marked as @experimental alongside AgentReasoningResponsePart and AgentReasoningResponsePartClientEvent.
AngeloGiacco
marked this pull request as ready for review
July 27, 2026 21:53
AngeloGiacco
enabled auto-merge (squash)
July 27, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the type generator to mark ALL types generated from an experimental payload as
@experimental, not just the root type.Problem
After merging PR #901, only the root types (
AgentReasoningResponsePartandAgentReasoningResponsePartClientEvent) were marked as experimental. The nested types (ReasoningResponsePartandReasoningResponsePartType) were missing the annotation.Solution
Modified the generator to iterate through all models generated from an experimental payload and add them to the
experimentalTypesset, ensuring all related types get the@experimentalJSDoc annotation.Types now marked as
@experimentalAgentReasoningResponsePartReasoningResponsePartReasoningResponsePartTypeAgentReasoningResponsePartClientEventRelated
Follow-up to PR #901
Slack Thread