#16 add the option to make RUMvision load with CSP compliance#17
Open
larsmbm wants to merge 1 commit into
Open
#16 add the option to make RUMvision load with CSP compliance#17larsmbm wants to merge 1 commit into
larsmbm wants to merge 1 commit into
Conversation
Contributor
|
I'm not seeing an option here? Just the XML and phtml, but no config, or ifconfig? |
Author
The commit message wasn’t accurate. I pushed this a bit too hastily. Could you let me know how you’d prefer the changes to this module to be handled so we can make it fully CSP compliant? We need to add a nonce for the inline script and include CloudFront in the allowlist. One option is to use Hyvä CSP, but that only works on Hyvä versions that support the CSP viewmodel. Also, for full CSP compliance we can’t keep using eval(), so that part still needs to be updated as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.