-
Notifications
You must be signed in to change notification settings - Fork 0
feat(desktop,onboarding): overhaul minimalist desktop app, visual diffs, dependency assistant, and re-triggerable onboarding (v0.5.15) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d18c597
feat(desktop,onboarding): overhaul minimalist desktop app, visual dif…
elijahbutler 9b5a51c
ci: add CircleCI pipeline for Bun, typecheck, lint, and test suites
elijahbutler 1fd5d1f
ci: route Bun and Desktop test jobs to self-hosted dev-01 runner
elijahbutler 763fec4
ci: remove CircleCI, prune heavy release packaging, and route PR chec…
elijahbutler f8a0a41
fix(review): address CodeRabbit feedback across diffs, onboarding, re…
elijahbutler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: elijahbutler/reglet
Length of output: 9630
🌐 Web query:
site:docs.github.com GitHub Actions permissions workflow-level job-level permissions unspecified read contents💡 Result:
In GitHub Actions, the behavior of unspecified permissions depends on whether you have explicitly defined a
permissionsblock in your workflow or job [1][2]. 1. When you explicitly define apermissionsblock (at either the workflow or job level), all permissions that are NOT explicitly listed in that block are set tonone(no access) [1][2]. This is a critical security feature designed to enforce the principle of least privilege [3]. The only exception is themetadatascope, which always retains read access [4]. 2. When you do NOT define anypermissionsblock, theGITHUB_TOKENdefaults to the permissions configured at the repository, organization, or enterprise level [4][5]. Administrators can set these defaults to either "permissive" (read/write access for most scopes) or "restricted" (read-only access for contents and packages) [6]. Key behaviors: * Workflow vs. Job Level: If you define permissions at the workflow level, they apply to all jobs in that workflow [2][5]. If you define them at the job level, they override any workflow-level permissions for that specific job [1][5]. * Implicit "None": By specifying even one permission in apermissionsblock, you opt out of the repository's default settings, meaning all other unspecified permissions are automatically set tonone[1][2]. Therefore, if you have apermissionsblock that specifiescontents: read, any other permission (likepackages,issues, etc.) will be set tonone, regardless of your repository's default settings [1][2].Citations:
Set an explicit read-only workflow default.
This workflow runs for every
v*tag. Without a top-levelpermissionsblock, build jobs inherit repository, organization, or enterprise defaults. Addpermissions: contents: readat workflow level and retain write permissions only forpublish-release.🧰 Tools
🪛 zizmor (1.29.0)
[warning] 1-251: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
🤖 Prompt for AI Agents
Source: Linters/SAST tools