Fix TypeScript API contracts and component rendering - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed all 43 component modules and validated the following fixes:
string | nullfor single selection andstring[]for multiple selection, rejects mismatched values, and preserves existing unparameterizedSelectPropsprop bags.titlecollision so their title slots accept React content as declared.contentsprecedence.disabled={false}children, and apply it to interaction and label styling.Validation completed:
npm run check— format, lint, typecheck, and 54 tests pass.npm run test:browserwithPLAYWRIGHT_EXECUTABLE_PATH— all 23 tests pass; reviewed rendered captures at 1280, 768, 390, and 320 pixels.npm run build,npm run build:docs, andnpm run pack:check— pass, including consumer declarations withskipLibCheck: false, SSR imports, and bundle budgets.The standard Playwright download timed out locally, so browser validation used a temporary npm-distributed Chromium executable. No browser dependency or version bump is included. Select/RadioGroup now intentionally reject non-string selections that cannot match their options.
Rendering fixes and docs simplification:
The rendering review record documents the findings, rejected styling change, simplifications, and validation. Re-reviewed at 1280, 768, 390, and 320px with no document overflow. All 54 unit tests, 23 browser tests, library/docs builds, and package checks pass locally. A separate clean production docs build confirms the stress fixtures are excluded. Browser coverage is Chromium only.
Release: bump package.json and package-lock.json from 0.6.2 to 0.6.3. The existing main-branch release workflow validates the merged commit and creates v0.6.3.