Skip to content

Fix O(n) walk in Access.slice/1 for :get_and_update past range.last #15336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
May 2, 2026
+5 −0
Merged

Fix O(n) walk in Access.slice/1 for :get_and_update past range.last #15336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/elixir/lib/access.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,6 +1091,11 @@ defmodule Access do

defp normalize_range(range, _list), do: range

defp get_and_update_slice(rest, %Range{last: last}, _next, updates, gets, index)
when index > last do
{:lists.reverse(gets), :lists.reverse(updates, rest)}
end

defp get_and_update_slice([head | rest], range, next, updates, gets, index) do
if index in range do
case next.(head) do
Expand Down
Loading