Scope ExUnit diff width tests#15396
Merged
Merged
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExUnit.DiffTestuse:infinityas the default diff formatting width.Context
This follows up on #13954 which changed the test helper to format at 80 columns globally to force-test the inserted/deleted map-in-list formatting. However, this introduced a latent issue in diffs that involve PIDs or Refs that have variable lengths, and such tests may fail intermittently such as in https://github.com/elixir-lang/elixir/actions/runs/25930787536/job/76225550506:
This PR keeps that finite-width coverage, but narrows it to deterministic layout assertions:
Other diff tests default back to
:infinity, which makes semantic checks independent from generated inspected values such as refs, pids, and functions.Tests
make test_ex_unitbin/mix format --check-formatted lib/ex_unit/test/ex_unit/diff_test.exsgit diff --check