Repository navigation
Conversation
Implements 37277 - Replaces ModemManager with pure Python AT command implementation ## Changes - ✅ New modem.py (315 lines) using pyserial and AT commands - ✅ Supports Quectel EG25 (comma 3X) and EG916 (comma four) - ✅ Replaces dbus with state file at /dev/shm/modem_state.txt - ✅ Maintains routing priority (WiFi > LTE) - ✅ Faster boot times (no ModemManager service) - ✅ Simpler, more reliable implementation ## Features - AT command interface via serial (ttyUSB2/ttyUSB0/ttyACM0) - SIM detection and configuration - LTE data connection management - Signal strength and temperature monitoring - Data usage tracking (TX/RX bytes) - Daemon mode with periodic state updates ## Testing - Syntax validated with py_compile - Ready for comma 3X and comma four hardware testing - Requires 10 Discord users to validate for ~1 week ## Notes - Requires pyserial dependency - APN configuration may need carrier-specific adjustment - Bonus target: <1 min boot to ping on comma four with prime Claiming bounty for issue 37277 cc @geohot @adeebshihadeh
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
1 similar comment
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: commaai/openpilot pull/37323
Summary
Implements 37277 - Replaces ModemManager with ~300 lines of pure Python using AT commands
Changes
system/hardware/tici/modem.pyusing pyserial and AT commands/dev/shm/modem_state.txtFeatures
Testing Plan
Benefits
Bonus Target ()
Working toward:
ping -c 1 google.com<1 min after powering up comma four with comma primeClaim Bounty
Claiming the bounty for issue 37277
cc @geohot @adeebshihadeh