Repository navigation
Conversation
Process replay diff
Process replay diff
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
Process replay diff
This reverts commit c4f2ab7.
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
1 similar comment
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Driver monitoring intended behavior is that when you are stopped = visual only, no audible.
This handles the edge case where someone was already at orange while driving and then stopped.
Description
When awareness is at orange level and vehicle is stopped, emit
preDriverDistracted(green/visual-only) instead ofpromptDriverDistracted(orange/audible).This aligns with comma's philosophy that driver monitoring shouldn't actively enforce when not moving (per George Hotz in https://youtu.be/-qf1NzI1I7E?t=52). The existing
standstill_orange_exemptionpauses countdown at the orange boundary, but if a driver was already at orange while driving and then stopped, they'd still hear the audible alert. This change downgrades it to visual-only at standstill.Behavior:
Verification
In
selfdrive/monitoring/test_monitoring.py:existing
test_long_traffic_light_victimpartially covers this:preDriverDistracted(green) while at standstill (59.9s)promptDriverDistracted(orange) after the car starts moving (60.5s)new
test_distracted_then_stops:threshold