Skip to content

cleanup: modem config - #97

Closed
elkoled wants to merge 5 commits into
masterfrom
pr-37330
Closed

elkoled wants to merge 5 commits into
masterfrom
pr-37330

Conversation

@elkoled

@elkoled elkoled commented Feb 24, 2026

Copy link
Copy Markdown
Owner

Upstream PR: commaai/openpilot pull/37330


mici also needs AT+QSIMDET=1,0 and AT+QSIMSTAT=1

otherwise SIM doesn't show up as "inserted" and switch commands don't cause it to re-register :-)

new behavior:

  • mici will get hotswap commands configured at boot

mici

  logmessaged timed ui deleter pandad hardwared tombstoned updated uploader statsd
  configuring modem
  modem revision: EG916QGLLGR01A05M04
  logmessaged timed ui deleter pandad hardwared tombstoned updated uploader statsd
  Failed to fetch prime status: System time is not valid, cannot generate token

tizi

  logmessaged timed ui deleter pandad hardwared tombstoned updated uploader statsd
  configuring modem
  modem revision: EG25GGBR07A08M2G
  logmessaged timed ui deleter pandad hardwared tombstoned updated uploader statsd
  Successfully set initial EPS bearer properties

greatgitsby and others added 5 commits February 22, 2026 20:23
Separate SIM hot swap commands (QSIMDET/QSIMSTAT) for EG25 and EG916,
keep data-centric config for EG25 only, and remove Cavli block.

Co-authored-by: Cursor <cursoragent@cursor.com>
The EG25 reports its Model as "QUECTEL Mobile Broadband Module" via
ModemManager dbus, not "EG25", so the model-based check never matched.
Use the Revision field (e.g. "EG25GGBR07A08M2G", "EG916QGLLGR01A05M04")
with startswith() for reliable modem identification.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Default to empty string, inline startswith checks directly.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@github-actions

Copy link
Copy Markdown

This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions Bot added the stale label Mar 25, 2026
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

1 similar comment
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions Bot closed this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants