Repository navigation
Conversation
Separate SIM hot swap commands (QSIMDET/QSIMSTAT) for EG25 and EG916, keep data-centric config for EG25 only, and remove Cavli block. Co-authored-by: Cursor <cursoragent@cursor.com>
The EG25 reports its Model as "QUECTEL Mobile Broadband Module" via ModemManager dbus, not "EG25", so the model-based check never matched. Use the Revision field (e.g. "EG25GGBR07A08M2G", "EG916QGLLGR01A05M04") with startswith() for reliable modem identification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Default to empty string, inline startswith checks directly. Co-authored-by: Cursor <cursoragent@cursor.com>
Process replay diff reportReplays driving segments through this PR and compares the behavior to master. ✅ 0 changed, 66 passed, 0 errors |
|
This PR has had no activity for 24 days. It will be automatically closed in 7 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
1 similar comment
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: commaai/openpilot pull/37330
mici also needs
AT+QSIMDET=1,0andAT+QSIMSTAT=1otherwise SIM doesn't show up as "inserted" and switch commands don't cause it to re-register :-)
new behavior:
mici
tizi