Repository navigation
Prepare 0.2.0 for CRAN submission - #6
Merged
Merged
Conversation
- Tests that call glmnet or caret now skip when the package is absent;
the suite passes with no suggested packages installed.
- Examples that run in under two seconds are no longer in \donttest{}, and
values computed inside guarded example blocks are printed.
- DESCRIPTION: reflow the Description, spell out LASSO, require
withr >= 2.4.0 (first release exporting local_seed()).
- cran-comments: describe the checks actually run (with and without
suggested packages), pre-empt the surname spelling NOTE, explain the
scoped earth attach in fs_mars(), and drop unverifiable counts.
- inst/WORDLIST: refresh for the reworked documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a pre-submission review against the CRAN Repository Policy and the revision requests CRAN reviewers commonly send.
Changes
skip_if_not_installed(). CRAN's checks without suggested packages would fail on them, which usually means revise and resubmit. They now skip. The full suite was run with no suggested packages installed: 0 failures.\donttest{}. Reviewers ask that\donttest{}be kept for examples that take more than about 5 seconds. Values computed inside guardedif (requireNamespace(...)) { }blocks are now printed, so the examples show output.fs_bayes()(compiles Stan) andfs_boruta()stay in\donttest{}.withr (>= 2.4.0), the first withr release that exportslocal_seed().fs_mars().spelling::spell_check_package()is clean.Verification
R CMD check --as-cranwas run twice, each with_R_CHECK_LIMIT_CORES_=TRUE:--run-donttestThe environment issues were: no UTF-8 locale, no qpdf, no network for the timestamp check, and Boruta, bigstatsr and PRROC unavailable.
fs_bayestakes at most 1.2 seconds.fs_bayestakes 5.8 seconds and is in\donttest{}.Still to run before submitting (needs network)
devtools::check_win_devel(): incoming checks, PDF manual, URL and DOI checks.urlchecker::url_check().tools::package_dependencies("featR", reverse = TRUE), to confirm there are no reverse dependencies.Generated by Claude Code