fix(Replay): improve finish detection #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makitalo
force-pushed
the
finish-detection
branch
from
c6992e5 to
9ff2a29
Compare
Fixes many edge cases (such as finishing with flower + apple, or escing/dying at flower), and improves multi rec handling. Added new tests with recs featuring these edge cases.
Due to handling flower+apple finishes properly now, EventType.Apple as last event doesn't count as NoTouch anymore for these cases.
makitalo
force-pushed
the
finish-detection
branch
from
9ff2a29 to
35dd4cf
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR improves the finish detection logic for replays by refining event parsing and using more robust time calculations, while also adding tests to cover various edge cases.
- Revised event parsing in Replay.ts to use an Event instance rather than raw object literals.
- Updated the finish detection logic in getTime to consider multi-rec edge cases and frame tolerances.
- Added new tests to validate singleplayer and multiplayer scenarios with edge conditions.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rec/Replay.ts | Updated event parsing and finish detection logic in getTime. |
| tests/rec.int.test.ts | Added tests covering new edge case scenarios. |
| src/rec/Event.ts | Introduced a getter for converting event time to milliseconds. |
Comments suppressed due to low confidence (1)
src/rec/Event.ts:14
- [nitpick] Extract the magic constant used for converting event time to milliseconds into a well-named constant to improve code clarity and maintainability.
get timeInMilliseconds(): number {
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
## [1.2.4](v1.2.3...v1.2.4) (2025-03-12) ### Bug Fixes * **Replay:** improve finish detection ([#425](#425)) ([86abf39](86abf39))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes many edge cases (such as finishing with flower + apple, or escing/dying at flower), and improves multi rec handling.
Added new tests with recs featuring these edge cases.
Closes #382.