WIP: Encode info about group and kind into respective types#29
Open
lobziik wants to merge 4 commits into
Open
Conversation
Clap stays at v3 due to v4 does not compile with stable rust
As initial step for the 'live cluster backend' it would be handy to have resource kind, group and scope encoded into respective resource types. Potentially this would allow to leverage specific types for constructing paths within mustgather, as well as use this information for query resources from a living kubernetes cluster.
Follow up to prev commit. Small refactor which moves pretty much constant info from hardcoded values into types for constructing paths to manifests within a mustgather.
Owner
|
excited to see what happens here =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work for #26
Idea behind this is to leverage types and constants associated with it for constructing paths within must-gather folder,
and potentially use this information for constructing queries for the live cluster backend.