Repository navigation
Fail adaptive DPDK mode when RX notifications are unavailable - #10
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adaptive mode can currently turn into polling when a PMD rejects RX interrupts or a queue cannot provide a usable notification descriptor. On a 16-worker Azure NetVSC run this made an idle
adaptiveserver consume 16 CPUs while reporting per-queue fallback messages.This change keeps both
pollandadaptive, including the existing default. Adaptive startup validates every hardware RX queue and fails with an explicitBYCORF_DPDK_MODE=pollsuggestion if notifications are unavailable. Notification registration and interrupt failures during execution terminate the server instead of silently spinning; peers are stopped before the all-worker teardown barriers.The mlx5 PMD acknowledges RDMA event-channel records itself. Its empty-channel
EAGAINon interrupt disable is valid after startup probes or timer/mailbox wakes, and is not treated as unsupported hardware. TAP packet descriptors and mlx5 event channels are not read as ordinary eventfds.Validation on Ubuntu 24.04, GCC 13, Release, DPDK/SPDK enabled:
git diff --checkpasses.Runtime and networking architecture documentation and the mode configuration guide are updated. On the Azure ConnectX-5 VF (
mlx5_pci), 16 adaptive workers and 16 RX/TX queues start successfully, recover a six-device SPDK dataset with one billion keys, and answer remote PING/DBSIZE. After recovery, idle process CPU averages 11.4% of one CPU (0.114 CPU) across five one-second samples; the previous NetVSC fallback consumed about 16 CPUs. These are idle-mode checks, not throughput results.