Skip to content

Guarantee compile-time initialization of scan arena tables #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thweetkomputer merged 1 commit into from
Oct 11, 2026
Merged

Guarantee compile-time initialization of scan arena tables #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions include/lavik/storage/scan_hash_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,23 +247,26 @@ ScanHashMapEntryArena::BuildClassSizes() noexcept {

constexpr std::array<std::uint8_t, 513>
ScanHashMapEntryArena::BuildClassLookup() noexcept {
constexpr auto sizes = BuildClassSizes();
std::array<std::uint8_t, 513> lookup{};
for (std::size_t units = 0; units < lookup.size(); ++units) {
const std::size_t bytes = units * 8;
std::size_t index = 0;
while (index + 1 < kClassSizes.size() && kClassSizes[index] < bytes) {
while (index + 1 < sizes.size() && sizes[index] < bytes) {
++index;
}
lookup[units] = static_cast<std::uint8_t>(index);
}
return lookup;
}

inline const std::array<std::uint16_t, ScanHashMapEntryArena::kSmallClassCount>
inline constexpr std::array<std::uint16_t,
ScanHashMapEntryArena::kSmallClassCount>
ScanHashMapEntryArena::kClassSizes =
ScanHashMapEntryArena::BuildClassSizes();
inline const std::array<std::uint8_t, 513> ScanHashMapEntryArena::kClassLookup =
ScanHashMapEntryArena::BuildClassLookup();
inline constexpr std::array<std::uint8_t, 513>
ScanHashMapEntryArena::kClassLookup =
ScanHashMapEntryArena::BuildClassLookup();

inline ScanHashMapEntryArena::ScanHashMapEntryArena(
std::uint32_t maximum_page_id, bool externally_admitted,
Expand Down
Loading