Skip to content

Default to immediate online mimalloc purging #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thweetkomputer merged 1 commit into from
Oct 20, 2026
Merged

Default to immediate online mimalloc purging #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lavik.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ int main(int argc, char** argv) {
->check(CLI::NonNegativeNumber);
app.add_option("--mimalloc-purge-delay-ms", options.mimalloc_purge_delay_ms_,
"Online mimalloc purge delay in ms, applied after recovery "
"(-1 disables purging)")
"(0 purges immediately, -1 disables purging)")
->capture_default_str()
->check(CLI::Range(-1L, std::numeric_limits<long>::max()));
app.add_option("--registered-buffer-mb-per-worker", registered_buffer_mb,
Expand Down
5 changes: 4 additions & 1 deletion include/lavik/server.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@

namespace lavik {

inline constexpr long kDefaultMimallocPurgeDelayMs = 60'000;
// Purge eligible pages immediately online so deferred reclamation does not
// accumulate on later allocations. Large frees can still pay synchronous purge
// costs. Recovery keeps mimalloc's native delay until all workers finish.
inline constexpr long kDefaultMimallocPurgeDelayMs = 0;
inline constexpr std::uint64_t kDefaultMaxClients = 10'000;

// One Redis `save <seconds> <changes>` policy. A background RDB save becomes
Expand Down