Skip to content

Remove mutex from DataStoreService #58

Closed
#67
#68
Closed
Remove mutex from DataStoreService#58
#67
#68
Assignees
lzxddz

Description

@lzxddz
lzxddz
opened on Aug 27, 2025

Use an vector to store all shards' datastore instead of use a shared_mutex.
Avoid creating a new CallbackData object every time we call functions of DataStoreServiceClient.
Remove rpc channel from all closures. Just fetch channel when use it.
Check whether the datastore is on current node at receive request instead of in datastore.

Activity

  1. lzxddz
    self-assigned this
    on Sep 2, 2025

  2. lzxddz commented on Sep 2, 2025

    @lzxddz
    lzxddz
    on Sep 2, 2025
    CollaboratorAuthor

    Aims to support multi engine, do "CreateTxKey" and "CreateTxRecord" in txservice instead of store_handler. (see FetchTableStatsCallback, LoadRangeSliceCallback, FetchTableRangesCallback ...)

  3. lzxddz commented on Sep 3, 2025

    @lzxddz
    lzxddz
    on Sep 3, 2025
    CollaboratorAuthor
    • Removed mutex from DataStoreService and only support one data shard in one DataStoreService node.
    • Removed rpc channel from all closures.
    • Reuse CallbackData objects and try merge variables in CallbackData into cc_request to avoid using CallbackData.
  4. lzxddz
    linked a pull request that will close this issueRemove lock serv_mux_ from DataStoreService #68on Sep 7, 2025
  5. lzxddz
    linked a pull request that will close this issueMerge some variables that only used in DataStoreServiceClient into relevant cc request. #67on Sep 7, 2025

  6. lzxddz commented on Sep 7, 2025

    @lzxddz
    lzxddz
    on Sep 7, 2025
    CollaboratorAuthor

    PR

    #67
    #68

  7. lzxddz commented on Sep 8, 2025

    @lzxddz
    lzxddz
    on Sep 8, 2025
    CollaboratorAuthor

    Do "CreateTxKey" and "CreateTxRecord" in txservice in another issue #69

  8. lzxddz
    closed this as completedin #67on Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions