Conversation
- deploy.yml: run Jest tests and Ruff lint before building images; each build job now requires its test/lint job to pass - ci.yml: scope to dev pushes and PRs to main (main is covered by the deploy pipeline) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… Select filter from ScanResultsPage
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR focuses on small UI cleanups, improving scan-detail freshness in the dashboard, and strengthening the GitHub Actions pipeline by adding backend tests and Python (Ruff) linting prior to building/deploying images.
Changes:
- Removed large blocks of commented-out UI code from Scan Results and shared report pages.
- Updated
useFetchScanDetailto always refetch when the query mounts. - Enhanced GitHub Actions by adding backend Jest tests and Ruff lint jobs, and adjusted CI workflow triggers/job naming.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| client/src/features/dashboard/ScanResults/index.tsx | Removes commented-out filter UI code. |
| client/src/features/dashboard/ScanResults/hooks.ts | Forces scan-detail queries to refetch on mount. |
| client/src/features/dashboard/Reports/components/SharePage.tsx | Removes commented-out sticky promo banner code. |
| .github/workflows/deploy.yml | Adds backend test + Ruff lint gates before build/push; updates build job dependencies. |
| .github/workflows/ci.yml | Adjusts CI push branches and normalizes job display names. |
Comment on lines
24
to
26
| enabled: !!id, | ||
| refetchOnMount: 'always', | ||
| }); |
Comment on lines
+89
to
92
| needs: [changes, test-backend] | ||
| if: needs.test-backend.result == 'success' | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Comment on lines
+108
to
111
| needs: [changes, lint-rag] | ||
| if: needs.lint-rag.result == 'success' | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Comment on lines
+127
to
130
| needs: [changes, lint-model] | ||
| if: needs.lint-model.result == 'success' | ||
| steps: | ||
| - uses: actions/checkout@v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.