Skip to content

feat(style): display units in character sheet#2582

Open
arcimboldo wants to merge 9 commits intoelyukai:develop-v2from
arcimboldo:show-units
Open

feat(style): display units in character sheet#2582
arcimboldo wants to merge 9 commits intoelyukai:develop-v2from
arcimboldo:show-units

Conversation

@arcimboldo
Copy link
Copy Markdown

This is a proof of concept PR, this is what I meant in #2581 (comment) when I suggested to at least show the units.

Show length and weight units in the overview and in the character sheet views.

This change introduces two new properties: general.weightunit and general.lengthunit; these are localized in the optolith-data repository in accordance with already existing general.weightvalue and general.lengthvalue and two functions to return the correct unit based on the current locale.
Screenshot_20260226_140010
Screenshot_20260226_135939

Note that this changes requires commit https://github.com/elyukai/optolith-data/commit/eecf87dcf3525d7926809fe36552f2dfd42d8119 which I am not sure how to merge, since the current optolith-client/develop branch seems to point to a very obsolete commit.

@arcimboldo arcimboldo requested a review from elyukai as a code owner February 26, 2026 13:15
@elyukai
Copy link
Copy Markdown
Owner

elyukai commented Mar 2, 2026

Thanks for the PR!

I mean, the V1 branches both here and in the data repository are kinda old. The most recent actual commit here on the V1 main branch (which is develop) is from July 22, 2022, while the most recent actual commit on the main data V1 branch (which is develop-V1) is from August 2, 2022. Development has diverged since then, which makes it difficult to still merge them into the V2 branches (except for fully manual ports, of course).

The develop-V2 branches in both repos are much more recent, with the data repo still being very active and with the client repo only having its most recent commit on October 7, 2024 because I have been extracting more and more into separate repositories. Which then does not show, because I have not updated the client branch to depend on those new repos/packages yet.

I am not sure if merging this into V1 would make a lot of sense at this point. I would rather see if it can be merged into the V2 branch. I do not think it is feasible to merge V1 database changes anymore, and I would rather adjust the V2 database directly.

@elyukai elyukai changed the base branch from develop to develop-v2 March 2, 2026 20:50
@elyukai
Copy link
Copy Markdown
Owner

elyukai commented Mar 2, 2026

I sadly do not really have time to look into the conflicts, as I also have not worked on the V2 here recently and would rather like to look into it once I am also more actively working on the client repo when I am done with extracting what I wanted to extract (which is going to be at some point this month I think). But then I can see how/if it can merged or if it would make more sense to rewrite it to match the V2 style first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants