feat(style): display units in character sheet#2582
feat(style): display units in character sheet#2582arcimboldo wants to merge 9 commits intoelyukai:develop-v2from
Conversation
Refs: elyukai#1634 Co-authored-by: Lukas Obermann <lukas.obermann@icloud.com>
|
Thanks for the PR! I mean, the V1 branches both here and in the data repository are kinda old. The most recent actual commit here on the V1 main branch (which is The I am not sure if merging this into V1 would make a lot of sense at this point. I would rather see if it can be merged into the V2 branch. I do not think it is feasible to merge V1 database changes anymore, and I would rather adjust the V2 database directly. |
|
I sadly do not really have time to look into the conflicts, as I also have not worked on the V2 here recently and would rather like to look into it once I am also more actively working on the client repo when I am done with extracting what I wanted to extract (which is going to be at some point this month I think). But then I can see how/if it can merged or if it would make more sense to rewrite it to match the V2 style first. |
This is a proof of concept PR, this is what I meant in #2581 (comment) when I suggested to at least show the units.
Show length and weight units in the overview and in the character sheet views.
This change introduces two new properties:


general.weightunitandgeneral.lengthunit; these are localized in the optolith-data repository in accordance with already existinggeneral.weightvalueandgeneral.lengthvalueand two functions to return the correct unit based on the current locale.Note that this changes requires commit https://github.com/elyukai/optolith-data/commit/eecf87dcf3525d7926809fe36552f2dfd42d8119 which I am not sure how to merge, since the current optolith-client/develop branch seems to point to a very obsolete commit.