feat: show equalizer bars while loading - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the plain grey loading text with four bouncing green equalizer bars above the same text.
src/components/Loading.tsx: the bars plus the message, withrole="status". The bars arearia-hidden, so screen readers hear the same text as before.App.tsx), "Loading your playlists…" (PlaylistPicker.tsx), and "Loading songs…" (SwipeScreen.tsx,DedupeScreen.tsx).styles.css: pure CSS. Each bar scales between 30% and 100% of its height, and the bars have different durations and delays so they don't move in lockstep. Underprefers-reduced-motionthey stand still at different heights.Notes for review
PlaylistPicker.tsxas feat: slide the highlight when switching modes #7, but on different lines, so the two should merge in either order.Testing
npm test: 129 passed.npm run build: succeeds.🤖 Generated with Claude Code