Repository navigation
fix: add SketchyI2IRetrieval v2 with one image per id - #5794
Open
AdnanElAssadi wants to merge 1 commit into
Open
AdnanElAssadi wants to merge 1 commit into
AdnanElAssadi wants to merge 1 commit into
Conversation
Member
But shoudn't we modify ids instead to use augmented images? |
11 of 24 tasks
Contributor
Author
we can. I dont think scores would change much though but probably 6x compute |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SketchyI2IRetrievalhas several rows under the same id. Each sketch is stored 6 times (the Sketchy augmentations: the same drawing shifted and scaled), and each photo twice (two crops), all with the same id: 452,886 query rows for 75,481 ids, and 25,000 corpus rows for 12,500 ids.Results are keyed by id, so only one copy of each ends up counting, but every model still encodes all the copies, and the same photo id can appear twice in a ranking.
This adds
SketchyI2IRetrieval.v2, which keeps the first row of each id in queries and corpus, and marks the old task as superseded. The descriptive stats are generated for v2.openai/clip-vit-base-patch32, full test set:The score changes a little because in v1 the copy that ends up counting depends on how duplicate ids are merged.