Repository navigation
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| this.#emitter.emit('loggedOut', oldUser); | ||
| } | ||
|
|
||
| // Public subscription methods |
There was a problem hiding this comment.
also, maybe
on(event, callbark) {
return this.#emitter.on(event, callbark);
}There was a problem hiding this comment.
but what you have is easier to be type-safe
|
|
||
| Please note: The methods from `Evented` (`on`, `one`, `off`, `trigger`, `has`) were also available on `Ember.Component`, `Ember.Route`, and `Ember.Router`. While usage on these objects is deprecated, the methods will continue to be supported and not deprecated on the `RouterService`, since key parts of its functionality are difficult to reproduce without them. | ||
|
|
||
| ### Replacing `Evented` with `emittery` |
There was a problem hiding this comment.
Oof, for any application at scale this is going to be a pretty huge change. Switching from synchronous events to asynchronous events is almost certain to not just be a drop-in replacement like this, and this deprecation guide doesn't mention that at all.
It looks like this deprecation guide is simultaneously doing two things:
- Describing the deprecation of
Evented, and providing a possible path away from it - Recommending that users make the architectural change of switching from synchronous event emitting to asynchronous event emitting.
I think these really need to be called out separately. Users should be aware that if they just follow this deprecation guide mechanically they'll be changing timing characteristics of their application in ways that can (and in many cases almost certainly will) break things. So I think we need to be more explicit that we're both recommending a new library to use and the change from synchronous to asynchronous events, and ideally offer up a recommendation of a synchronous eventing library for users that aren't ready to make that change but still need to deal with this deprecation.
There was a problem hiding this comment.
Thanks for this callout. I would have thought existing events are async via the runloop. However, if we're sure this isn't the case, then we can definitely call it out in this guide.
There was a problem hiding this comment.
Observers are async by default, @ember/object/events and Evented are synchronous
There was a problem hiding this comment.
I've updated the guides to make this clear.
|
Is there a deprecation plan for But deprecating This guide seems to be addressing cases where |
|
@bendemboski I've updated the RFC to match this deprecation guide. |
| > ⚠️ Important: `Ember.Evented` emits events *synchronously*. Changing to a library with asynchronous behavior, while recommended, may lead to subtle changes in your application's behavior. | ||
|
|
||
| Please note: The methods from `Evented` (`on`, `one`, `off`, `trigger`, `has`) were also available on `Ember.Component`, `Ember.Route`, and `Ember.Router`. While usage on these objects is deprecated, the methods will continue to be supported and not deprecated on the `RouterService`, since key parts of its functionality are difficult to reproduce without them. | ||
|
|
There was a problem hiding this comment.
Shouldn't our first suggestion be to call methods directly where possible? If someone was using Evented with the example below I do not think my first suggestion would be to use Emittery but to refactor away from the pattern entirely.
I also think this needs examples for where it was used within Ember.Component, and Ember.Route and Router for the modern equivalents.
For example, for Ember Component, we should suggest moving to Glimmer components but also mention that instead of on('didInsertElement') that the hooks can be used directly.
They were also common with ember-simple-auth so we should suggest upgrading that addon or moving to the newer patterns there.
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
kategengler
left a comment
kategengler
left a comment
There was a problem hiding this comment.
I still think explicitly calling out replacing @ember/component with @glimmer/component but then discussing didInsertElement, willDestroy etc that were typically used with on would be good.
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
Co-authored-by: Katie Gengler <katie@kmg.io>
|
|
||
| The call is type-safe, and `logout` now states what it does instead of hiding the wiring in a subscription registered somewhere else. | ||
|
|
||
| ### Classic component lifecycle hooks |
There was a problem hiding this comment.
Evented and @ember/component are about to be deprecated, so this prose should be take that in to consideration.
The before examples should at least look like code that someone might accidentally write today, rather than inherited from 10 years ago
(a migration this old could be useful as a last example, I suppose)
This branch has not been deployed
5 participants
RFC: emberjs/rfcs#1111