docs(ember): add deprecation guide for Comparable mixin - #1432
Merged
NullVoxPopuli merged 5 commits intoSep 1, 2026
Merged
NullVoxPopuli merged 5 commits into
NullVoxPopuli merged 5 commits into
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
19 tasks
Add migration guide for the Comparable mixin deprecation in Ember v6, showing how to replace mixin usage with a direct compare() method.
NullVoxPopuli
force-pushed
the
add-comparable-mixin-deprecation-guide
branch
from
August 31, 2026 23:26
41573ee to
e22c88f
Compare
NullVoxPopuli
force-pushed
the
add-comparable-mixin-deprecation-guide
branch
from
August 31, 2026 23:27
e22c88f to
9880088
Compare
ef4
approved these changes
Sep 1, 2026
NullVoxPopuli
enabled auto-merge
September 1, 2026 15:17
kategengler
reviewed
Sep 1, 2026
| --- | ||
| title: Deprecate Comparable mixin | ||
| until: 8.0.0 | ||
| since: 7.2.0 |
Contributor
There was a problem hiding this comment.
It did, but it is also until 7.5 because it was private, so just an intimate api
kategengler
reviewed
Sep 1, 2026
Co-authored-by: Katie Gengler <katie@kmg.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the deprecation guide for
deprecate-comparable-mixin.This matches the deprecation entry added in Ember:
id: deprecate-comparable-mixinsince: 7.2.0until: 8.0.0https://deprecations.emberjs.com/id/deprecate-comparable-mixinThe guide explains that apps and addons should stop importing/extending the
Comparablemixin and instead define a function-valuedcompare(other)method directly.Refs emberjs/ember.js#21437