Replace jscodeshift with ember-estree - #32
Merged
NullVoxPopuli merged 1 commit intoSep 4, 2026
Merged
Conversation
unprocess now parses with ember-estree's toTree, swaps each template(`...`) call for a GlimmerTemplate node that holds the raw template text, drops the @ember/template-compiler import, and prints the tree with ember-estree's print. ember-estree prints the whole file from the AST, so untouched code is reformatted. jscodeshift kept the original formatting of untouched code. ember-estree depends on oxc-parser, which needs Node 20.19 or 22.12 and newer. The engines field moves up to match. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fvnp457DHuZC4fBa2KCiqB
NullVoxPopuli-ai-agent
marked this pull request as ready for review
September 4, 2026 23:29
NullVoxPopuli-ai-agent
force-pushed
the
nvp/ember-estree
branch
from
September 4, 2026 23:29
ac90d78 to
987ebbd
Compare
NullVoxPopuli
approved these changes
Sep 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
jscodeshiftand@types/jscodeshift.unprocessnow uses ember-estree 0.8.1.How
unprocessworks nowtoTreeparses the processed JS or TS.@ember/template-compilerimport and records the local name oftemplate.template(...)call, and eachstatic { template(...) }block, becomes aGlimmerTemplatenode with one text child that holds the raw template text. The text is not parsed as Glimmer, so it prints back verbatim.printwrites the tree back out.Behavior changes
engines.nodemoves from>= 18to^20.19.0 || >=22.12.0. ember-estree depends on oxc-parser, which needs those versions. This is a breaking change for consumers on Node 18.ember-estree 0.8.1 includes the printer fix from NullVoxPopuli/ember-estree#84, which this port needs. All 70 tests pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Fvnp457DHuZC4fBa2KCiqB