Merged
Conversation
SergeAstapov
approved these changes
Dec 27, 2024
Contributor
Author
|
This is sitting in draft as I'm not having any luck finding anyone who can release this addon. I want to do a release of current |
|
Also we no longer need |
Member
|
I cut a new release, so please proceed with this! |
New lockfile and then pulled the current pnpm addon blueprint changes in to update everywhere else yarn was mentioned.
Contributor
Author
|
Excellent! I rebased, CI doesn't seem to be running though. Not sure why. |
RobbieTheWagner
approved these changes
Mar 6, 2025
Member
|
This all looks good to me! I am not sure why CI is not running either, but maybe merging it will run it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New lockfile and then pulled the current
pnpmaddon blueprint changesember addon --pnpmin to update everywhere else yarn was mentioned. The only change from the defaultpnpmaddon blueprint is that I went withpnpmv9 for CI.