deprecate the target_action_support mixin, the action_handler mixin, send(), triggerAction()

[NullVoxPopuli]

Deprecates TargetActionSupport

RFC:

• Deprecate target action support. rfcs#1041

Advancement:

• Advance RFC #1041 "Deprecate TargetActionSupport" to Stage Ready for Release rfcs#1126

Supersedes

• Deprecate TargetActionSupport, ActionHandler#send, and ActionSupport#send (RFC 1041) #21490

History

• @wagenet started this in [WIP] Deprecate TargetActionSupport #20969
• I had my bot create Deprecate TargetActionSupport, ActionHandler#send, and ActionSupport#send (RFC 1041) #21490
• @ef4 questioned if we could deprecate usage of the whole module
  • I tried to deprecate on init, but this is insufficient, as it flags our own internal usage (from classic @ember/component)
  • However! I realized what @ef4 was alluding to: is we have a module-level declaration which triggers when consumers import the code, but our own internal code will import from a more private location, avoiding the deprecation

Note

it's at this point I realize that these mixins are all private and can't actually be imported by users
so the bots initial strategy of deprecating the specific send/trigger methods is the right way to go for now

• https://emberobserver.com/code-search?codeQuery=TargetActionSupport
• https://emberobserver.com/code-search?codeQuery=%5CbActionHandler&regex=true&sort=updated&sortAscending=false

Important

Previous use of these mixins was available through the Ember global, or barrel-import -- which we've removed.

[github-actions]

📊 Size report

Tarball size — 1.2 MB → 1.2 MB

dist/dev   0.05%↑

File	Before (Size / Brotli)	After (Size / Brotli)
./packages/@ember/-internals/deprecations/index.js	5 kB / 1.5 kB	5%↑5.3 kB / 2%↑1.6 kB
./packages/@ember/-internals/runtime/lib/mixins/action_handler.js	5.8 kB / 1.6 kB	6%↑6.1 kB / 7%↑1.7 kB
./packages/@ember/-internals/runtime/lib/mixins/target_action_support.js	4.6 kB / 1.2 kB	7%↑4.9 kB / 10%↑1.3 kB
./packages/@ember/-internals/views/lib/mixins/action_support.js	1.2 kB / 493 B	19%↑1.5 kB / 20%↑594 B
Total (Includes all files)	2.1 MB / 498 kB	0.05%↑2.1 MB / 0.07%↑498.3 kB

---

dist/prod   0.06%↑

File	Before (Size / Brotli)	After (Size / Brotli)
./packages/@ember/-internals/deprecations/index.js	4.7 kB / 1.5 kB	6%↑5 kB / 3%↑1.5 kB
./packages/@ember/-internals/runtime/lib/mixins/action_handler.js	5.3 kB / 1.4 kB	6%↑5.6 kB / 9%↑1.6 kB
./packages/@ember/-internals/runtime/lib/mixins/target_action_support.js	4.3 kB / 1.2 kB	7%↑4.6 kB / 8%↑1.3 kB
./packages/@ember/-internals/views/lib/mixins/action_support.js	615 B / 280 B	38%↑851 B / 37%↑383 B
Total (Includes all files)	1.9 MB / 455.4 kB	0.06%↑1.9 MB / 0.08%↑455.8 kB

---

smoke-tests/v2-app-template/dist   0.2%↑

File	Before (Size / Brotli)	After (Size / Brotli)
./assets/api-{hash}.js	287.8 kB / 77.4 kB	0.1%↑288.1 kB / 0.1%↑77.5 kB
./assets/modules-{hash}.js	40.6 kB / 12.5 kB	0.6%↑40.8 kB / 1%↑12.6 kB
Total (Includes all files)	351.1 kB / 97.8 kB	0.2%↑351.7 kB / 0.2%↑98 kB

---

smoke-tests/v2-app-hello-world-template/dist   0%↑

File	Before (Size / Brotli)	After (Size / Brotli)
Total (Includes all files)	132.4 kB / 37.1 kB	0%↑132.4 kB / -0.31%↓37 kB

_{🤖 This report was automatically generated by wyvox/pkg-size}