LowLevelRegisters tuple order and drop unused register helpers - #21605
Open
NullVoxPopuli wants to merge 2 commits into
Open
NullVoxPopuli wants to merge 2 commits into
NullVoxPopuli wants to merge 2 commits into
Conversation
Split out of nvp/simplify-some-vm-hot-paths. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
NullVoxPopuli
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
NullVoxPopuli
commented
Sep 21, 2026
NullVoxPopuli
commented
Sep 21, 2026
| export function initializeRegistersWithPC(pc: number): LowLevelRegisters { | ||
| return [pc, -1, 0, 0]; | ||
| } | ||
| export type LowLevelRegisters = [$pc: number, $ra: number, $fp: number, $sp: number]; |
Contributor
Author
There was a problem hiding this comment.
labels on an array type don't materr all that much, but they didn't originally agree with the index-order in lib/vm/stack (even though the original type matched what the removed (unused) helpers were doin'
the source of truth for what these labeled indicies are: vm/lib/register.ts (also imported in lib/vm/stack)
pc = 0
ra = 1
fp = 2
sp = 3
(so the code on the left was always wrong) 🙈
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
afaik, this is mostly cleanup