[BUGFIX release] Include renderComponent roots in captureRenderTree - #21620
Closed
NullVoxPopuli-ai-agent wants to merge 2 commits into
Closed
NullVoxPopuli-ai-agent wants to merge 2 commits into
NullVoxPopuli-ai-agent wants to merge 2 commits into
Conversation
…mponent Components rendered with `renderComponent` are missing from `captureRenderTree(owner)`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
`renderComponent` renders with its own renderer for each owner. `captureRenderTree` only read the owner's `renderer:-dom`, so those roots never showed up. `@ember/test-helpers` 5.5.0 renders through `renderComponent` on Ember 6.8 and newer. Since its release, `captureRenderTree` in a rendering test returns nothing, which broke the nightly smoke tests on `beta` and `release`. The renderer now registers itself with `@ember/debug`, and `captureRenderTree` includes its roots. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
is real issue... :( 
|
Contributor
Author
|
Closing in favor of #21622, which targets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly
Cronfailures onbetaandrelease. They started on 2026-09-23 (first beta run, first release run).captureRenderTree(owner)only reads the owner'srenderer:-dom.renderComponentrenders with its own renderer for each owner, so its components never show up.@ember/test-helpers5.5.0 (emberjs/ember-test-helpers#1573, published 2026-09-22) renders throughrenderComponenton Ember 6.8 and newer.The smoke tests install without the lockfile, so the next cron run picked it up, and all 8 smoke jobs failed with:
mainis not affected.There, the application seeds its own renderer into the
renderComponentcache (setRenderer, from the RFC 1169 work), so both share one render tree.That change is too big to backport, so this is a smaller fix:
renderComponentrenderer registers itself with@ember/debugcaptureRenderTreeadds its roots after therenderer:-domrootsThe registration goes in that direction because
@ember/debugimporting the renderer is a circular import.Two commits, so CI shows the failure first.
Same change for
beta: #21621.Checked locally:
strictResolver-basicssmoke scenario with test-helpers 5.5.0 fails without the fix (same message as CI) and passes with it🤖 Generated with Claude Code