Skip to content

Chpater59 sfpe#65

Open
simonsantama wants to merge 11 commits intomainfrom
chpater59_sfpe
Open

Chpater59 sfpe#65
simonsantama wants to merge 11 commits intomainfrom
chpater59_sfpe

Conversation

@simonsantama
Copy link
Contributor

Equations for 1st order hydraulic model. Still missing 59-10 and 59-11

Copilot AI review requested due to automatic review settings March 11, 2026 21:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds SFPE Handbook Chapter 59 to the Rust sfpe_handbook crate and exposes the implemented equations (59.5–59.9) through the PyO3 ofire Python API, with Sphinx API documentation updates.

Changes:

  • Introduces Chapter 59 Rust modules with equation implementations and unit tests for equations 59.5–59.9.
  • Adds Python bindings (PyO3) for Chapter 59 equations and wires the new chapter into the sfpe_handbook Python module.
  • Updates Sphinx docs to include Chapter 59 modules; includes minor formatting cleanups in Chapter 50 files.

Reviewed changes

Copilot reviewed 20 out of 23 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
crates/sfpe_handbook/src/lib.rs Exposes chapter_59 from the Rust SFPE Handbook crate.
crates/sfpe_handbook/src/chapter_59.rs Declares Chapter 59 equation submodules.
crates/sfpe_handbook/src/chapter_59/equation_59_5.rs Implements Eq. 59.5 (travel speed) + tests + equation-string helper.
crates/sfpe_handbook/src/chapter_59/equation_59_6.rs Implements Eq. 59.6 (specific flow) + tests + equation-string helper.
crates/sfpe_handbook/src/chapter_59/equation_59_7.rs Implements Eq. 59.7 (combined specific flow) + tests + equation-string helper.
crates/sfpe_handbook/src/chapter_59/equation_59_8.rs Implements Eq. 59.8 (calculated flow) + tests + equation-string helper.
crates/sfpe_handbook/src/chapter_59/equation_59_9.rs Implements Eq. 59.9 (combined calculated flow) + tests + equation-string helper.
crates/sfpe_handbook/src/chapter_59/equation_59_10.rs Adds an unimplemented placeholder (currently panics).
crates/sfpe_handbook/src/chapter_59/equation_59_11.rs Adds an unimplemented placeholder (currently panics).
crates/sfpe_handbook/src/chapter_50/equation_50_17.rs Formatting-only change to the equation-string helper signature.
crates/sfpe_handbook/src/chapter_50/equation_50_16.rs Formatting-only whitespace cleanup.
crates/python_api/src/sfpe_handbook.rs Exposes chapter_59 in the Python API sfpe_handbook module.
crates/python_api/src/sfpe_handbook/chapter_59.rs Adds Chapter 59 Python submodule wiring (wrap_pymodule).
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_5.rs PyO3 binding + docstring for Eq. 59.5.
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_6.rs PyO3 binding + docstring for Eq. 59.6.
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_7.rs PyO3 binding + docstring for Eq. 59.7.
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_8.rs PyO3 binding + docstring for Eq. 59.8.
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_9.rs PyO3 binding + docstring for Eq. 59.9.
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_10.rs PyO3 placeholder returning NotImplementedError + placeholder docs.
crates/python_api/src/sfpe_handbook/chapter_59/equation_59_11.rs PyO3 placeholder returning NotImplementedError + placeholder docs.
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_20.rs Formatting-only trailing brace alignment.
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_17.rs Formatting-only trailing brace alignment.
crates/python_api/docs/api/sfpe-handbook.rst Adds Chapter 59 API documentation entries.

You can also share your feedback on Copilot code review. Take the survey.

@simonsantama
Copy link
Contributor Author

@JamieMaclean
Implements equation of chapter 59 on hydraulic model for egress calcs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants