Conversation
|
Please wait a bit. We'll have to set up secrets for releases, and also to change the versioning/releasing strategy (i.e. set |
|
@dmikurube, Would you like to release a new version? As far as I remember, #259 hasn't been released yet. This PR fixes the one Connecotr/J 8.x issue. |
dmikurube
left a comment
dmikurube
left a comment
There was a problem hiding this comment.
Ah, sorry, forgot about it. We may want to release a new version, but as I commented above :
- Secrets/variables are not set (so it wouldn't work)
- We'll want to change the versioning/releasing strategy
Can you try (2) when you have time? Then I'll work on (1).
.github/workflows/publish.yml
Outdated
| printf -- "---\n:rubygems_api_key: ${RUBYGEMS_API_KEY}\n" > $HOME/.gem/credentials | ||
| ./gradlew --stacktrace publishMavenPublicationToMavenCentralRepository gemPush | ||
| env: | ||
| ORG_GRADLE_PROJECT_ossrhUsername: ${{ secrets.OSSRH_USERNAME }} |
There was a problem hiding this comment.
We recently use vars instead of secrets for username. (See some other repos.)
There was a problem hiding this comment.
|
The CI of changing 5b87aa1 failed due to a problem with SQL Server. I believe the CI error doesn't relate to this change. (I'll try to fix the CI problem on another PR.) |
|
Yeah, it does not look related, but we may need to dive into it... |
hiroyuki-sato
force-pushed
the
embulk/publish-github-actions
branch
from
5b87aa1 to
8286a28
Compare
|
@dmikurube I fixed the SQL server issue on #271, so I changed the base commit to the latest. |
2 participants
.github/workflows/publish.ymlfrom embulk-input-s3