Skip to content

feat: Expose device connector params#37

Open
flxapps wants to merge 1 commit intodevfrom
feat/expose-device-connector-params
Open

feat: Expose device connector params#37
flxapps wants to merge 1 commit intodevfrom
feat/expose-device-connector-params

Conversation

@flxapps
Copy link

@flxapps flxapps commented Oct 8, 2025

Expose DeviceConnector Parameters to IMP Components

Exposes ReaderConnectorMode and StorageAdapter parameters to ImpWidget, ImpModalBuilder, and impModal function, allowing consumers to customize device connection behavior (ephemeral, pair, or preferLastConnected modes) and provide custom storage adapters for persisting device preferences.

Changes

  • Added readerConnectorMode parameter to ImpWidget, ImpModalBuilder, and impModal (defaults to ReaderConnectorMode.preferLastConnected)
  • Added storageAdapter parameter to all three components (optional)
  • Parameters are properly passed through the component hierarchy to DeviceConnector

Related to https://github.com/merckgroup/mtrust-docs/issues/248.

@flxapps flxapps self-assigned this Oct 8, 2025
Copilot AI review requested due to automatic review settings October 8, 2025 10:17
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2025

CLA assistant check
All committers have signed the CLA.

@flxapps flxapps changed the base branch from main to dev October 8, 2025 10:17
@flxapps flxapps force-pushed the feat/expose-device-connector-params branch from c61b366 to a3bc238 Compare October 8, 2025 10:18
@ElectricCookie
Copy link

LGTM!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants