fix(ramshared): guard clauses for request queue initialization parameters - #1904
emersonbusson wants to merge 4 commits into
Conversation
…ters Refactor ramshared_queue_init to validate queue depth and device pointer non-nullness with early guard returns, replacing clamp_t logic with strict boundary validation returning -EINVAL for invalid parameters, meeting architecture guidelines. Rollback trigger: If the driver fails to initialize queues with legitimate q_depth values, revert this commit.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ters Refactor ramshared_queue_init to validate queue depth and device pointer non-nullness with early guard returns, replacing clamp_t logic with strict boundary validation returning -EINVAL for invalid parameters, meeting architecture guidelines. Rollback trigger: If the driver fails to initialize queues with legitimate q_depth values, revert this commit.
…ters Refactor ramshared_queue_init to validate queue depth and device pointer non-nullness with early guard returns, replacing clamp_t logic with strict boundary validation returning -EINVAL for invalid parameters, meeting architecture guidelines. Rollback trigger: If the driver fails to initialize queues with legitimate q_depth values, revert this commit.
…ters Refactor ramshared_queue_init to validate queue depth and device pointer non-nullness with early guard returns, replacing clamp_t logic with strict boundary validation returning -EINVAL for invalid parameters, meeting architecture guidelines. Rollback trigger: If the driver fails to initialize queues with legitimate q_depth values, revert this commit.
|
Closed in favor of PR #2085 consolidation. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
Summary
Refactor ramshared_queue_init to validate queue depth and device pointer non-nullness with early guard returns, replacing clamp_t logic with strict boundary validation returning -EINVAL for invalid parameters, meeting architecture guidelines.
Commits
Details
Files:drivers/block/ramshared/queue.cValidation: CI scripts
Risk/rollback: Revert if q_depth values fail init
Issue
N/A
Owner
jules
Labels
type:bug,area:kernelValidation
Checkpatch, style scripts, and ABI guards.
Rollback trigger
If the driver fails to initialize queues with legitimate q_depth values, revert this commit.
PR created automatically by Jules for task 1754927304022925084 started by @emersonbusson