Skip to content

fix(ramshared): return semantic blk_status_t errors for invalid requests #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emersonbusson wants to merge 4 commits into from
Closed

fix(ramshared): return semantic blk_status_t errors for invalid requests #1905

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecf58d2
fix(ramshared): return semantic blk_status_t errors for invalid requests
emersonbusson Sep 18, 2026
7289c96
fix(ramshared): return semantic blk_status_t errors for invalid requests
emersonbusson Sep 18, 2026
c7ff49a
fix(ramshared): return semantic blk_status_t errors for invalid requests
emersonbusson Sep 18, 2026
889dee3
fix(ramshared): return semantic blk_status_t errors for invalid requests
emersonbusson Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions drivers/block/ramshared/queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,6 @@
#include "ramshared.h"
#include "compat.h"

static blk_status_t ramshared_errno_to_blk_status(int err)
{
switch (err) {
case -ENOMEM:
return BLK_STS_RESOURCE;
case -EOPNOTSUPP:
return BLK_STS_NOTSUPP;
default:
return BLK_STS_IOERR;
}
}

static blk_status_t ramshared_process_bio(struct ramshared_device *rs_dev,
struct bio *bio, loff_t pos)
Expand All @@ -40,7 +29,7 @@ static blk_status_t ramshared_process_bio(struct ramshared_device *rs_dev,
dev_err_ratelimited(rs_dev->dev,
"Unaligned bio: pos=%lld, len=%u\n",
pos, bio->bi_iter.bi_size);
return ramshared_errno_to_blk_status(-EINVAL);
return BLK_STS_IOERR;
}

if (unlikely(pos > rs_dev->dma.size ||
Expand All @@ -50,7 +39,7 @@ static blk_status_t ramshared_process_bio(struct ramshared_device *rs_dev,
"Bio bounds violation: pos=%lld, len=%u, cap=%llu\n",
pos, bio->bi_iter.bi_size,
rs_dev->capacity_bytes);
return ramshared_errno_to_blk_status(-ERANGE);
return BLK_STS_IOERR;
}

vram_ptr = rs_dev->dma.cpu_addr + pos;
Expand Down Expand Up @@ -88,17 +77,17 @@ static blk_status_t ramshared_queue_rq(struct blk_mq_hw_ctx *hctx,
struct bio *bio;

if (unlikely(!rs_dev || !rs_dev->dma.cpu_addr))
return ramshared_errno_to_blk_status(-EIO);
return BLK_STS_IOERR;

if (unlikely(check_shl_overflow((loff_t)blk_rq_pos(rq), RAMSHARED_SECTOR_SHIFT, &pos)))
return ramshared_errno_to_blk_status(-ERANGE);
return BLK_STS_IOERR;

if (unlikely(!IS_ALIGNED(pos, RAMSHARED_SECTOR_SIZE) ||
!IS_ALIGNED(len, RAMSHARED_SECTOR_SIZE))) {
dev_err_ratelimited(rs_dev->dev,
"Unaligned I/O request: pos=%lld, len=%zu\n",
pos, len);
return ramshared_errno_to_blk_status(-EINVAL);
return BLK_STS_IOERR;
}

if (unlikely(pos > rs_dev->dma.size ||
Expand All @@ -108,7 +97,7 @@ static blk_status_t ramshared_queue_rq(struct blk_mq_hw_ctx *hctx,
"I/O bounds violation: pos=%lld, len=%zu, cap=%llu, mapped=%zu\n",
pos, len, rs_dev->capacity_bytes,
rs_dev->dma.size);
return ramshared_errno_to_blk_status(-ERANGE);
return BLK_STS_IOERR;
}

blk_mq_start_request(rq);
Expand Down
Loading