Skip to content

io_uring SQE cancellation handling on peer socket disconnect - #1925

Closed
emersonbusson wants to merge 1 commit into
mainfrom
fix-uring-cancellation-12350082151942420581
Closed

emersonbusson wants to merge 1 commit into
mainfrom
fix-uring-cancellation-12350082151942420581

Conversation

@emersonbusson

Copy link
Copy Markdown
Owner

Summary

Replaced single user_data cancellation with cancel_requests_by_fd using AsyncCancel2 and CancelBuilder::fd(...).all() to idempotently cancel all pending socket operations upon peer disconnect.

Commits

Commit Details
181e0c6
Filescrates/ramshared-uring/src/lib.rs

Validationcargo clippy, cargo test passes with simulated fd cancellation.

Risk/rollbackRollback if uring cancellation by fd misbehaves on older kernels.

Issue

Implements IPC Resilience Pillar: io_uring SQE cancellation handling on peer socket disconnect.

Owner

jules

Labels

type:feature, area:ramshared

Validation

Run cargo test -p ramshared-uring and cargo clippy -p ramshared-uring -- -D warnings.

Rollback trigger

Unintended termination of unrelated pending IO on concurrent FDs.


PR created automatically by Jules for task 12350082151942420581 started by @emersonbusson

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@emersonbusson

Copy link
Copy Markdown
Owner Author

Closed in favor of PR #2085 consolidation.

@emersonbusson
emersonbusson deleted the fix-uring-cancellation-12350082151942420581 branch September 23, 2026 15:04
@google-labs-jules

Copy link
Copy Markdown

Closed in favor of PR #2085 consolidation.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant