io_uring SQE cancellation handling on peer socket disconnect - #1925
emersonbusson wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closed in favor of PR #2085 consolidation. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Summary
Replaced single
user_datacancellation withcancel_requests_by_fdusingAsyncCancel2andCancelBuilder::fd(...).all()to idempotently cancel all pending socket operations upon peer disconnect.Commits
Files
crates/ramshared-uring/src/lib.rsValidation
cargo clippy, cargo test passes with simulated fd cancellation.Risk/rollback
Rollback if uring cancellation by fd misbehaves on older kernels.Issue
Implements IPC Resilience Pillar: io_uring SQE cancellation handling on peer socket disconnect.
Owner
jules
Labels
type:feature, area:ramshared
Validation
Run
cargo test -p ramshared-uringandcargo clippy -p ramshared-uring -- -D warnings.Rollback trigger
Unintended termination of unrelated pending IO on concurrent FDs.
PR created automatically by Jules for task 12350082151942420581 started by @emersonbusson