Skip to content

test: add fuzz-style tests for malformed protocol frames - #1929

Closed
emersonbusson wants to merge 3 commits into
mainfrom
fix-proto-tests-3323660221575908873
Closed

emersonbusson wants to merge 3 commits into
mainfrom
fix-proto-tests-3323660221575908873

Conversation

@emersonbusson

Copy link
Copy Markdown
Owner

Summary

Add fuzz-style tests in crates/ramshared-winsvc/src/proto.rs covering truncated headers, wrong magic bytes, and oversized length fields via a local mock parser.

Commits

SHA Files Validation Risk/rollback
f0d311d
Detailscrates/ramshared-winsvc/src/proto.rs
Detailscargo test
DetailsRollback if CI fails

Issue

ITEM-4

Owner

jules

Labels

type:test,area:ramshared

Validation

cargo test -p ramshared-winsvc passed locally.

Rollback trigger

Test failures on alternative architectures.

Contractual Blocks

  1. RULES: Met.
  2. MAIN_DIFF: Added mock_parser and tests.
  3. FILES: crates/ramshared-winsvc/src/proto.rs
  4. INVARIANTS: Mock tests do not affect production code.
  5. COUNTERFACTUAL: Valid headers and boundary errors are verified.
  6. RED_TEST: u32::MAX checked explicitly.
  7. COVERAGE: Yes.
  8. REAL_PROOF: cargo test passing.
  9. ROLLBACK: Build failure.
  10. PR_BOUNDARY: jules/inbox target branch.

PR created automatically by Jules for task 3323660221575908873 started by @emersonbusson

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@emersonbusson

Copy link
Copy Markdown
Owner Author

Closed in favor of PR #2085 consolidation.

@emersonbusson
emersonbusson deleted the fix-proto-tests-3323660221575908873 branch September 23, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant