Skip to content

fix: add CmdletBinding and guard clauses to Run-GuestExhaustive.ps1 - #1938

Closed
emersonbusson wants to merge 1 commit into
mainfrom
fix-ps1-validation-16395624662253526564
Closed

emersonbusson wants to merge 1 commit into
mainfrom
fix-ps1-validation-16395624662253526564

Conversation

@emersonbusson

Copy link
Copy Markdown
Owner

Summary

Adds [Parameter(Mandatory = $false)], [ValidateSet()], and [ValidateNotNullOrEmpty()] to $VMName. Adds early guard clauses using typed exceptions to check Hyper-V module and VM existence.

Commits

SHA Files Validation Risk/rollback
28c025e
Details
  • scripts/windows/Run-GuestExhaustive.ps1
DetailsVerified syntax correctly validates Hyper-V module and VM existence
DetailsLow risk. Rollback if script validation behaves unexpectedly.
d61ffdd
Details
  • scripts/windows/Run-GuestExhaustive.ps1
DetailsVerified syntax correctly applies typed exceptions and ValidateSet
DetailsLow risk. Rollback if script execution fails due to unknown exception types.

Issue

Fixes #1

Owner

jules

Labels

type:bug,area:ps1-windows

Validation

Verified file syntax correctly applies changes.

Rollback trigger

Revert if pipeline fails downstream.


PR created automatically by Jules for task 16395624662253526564 started by @emersonbusson

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@emersonbusson

Copy link
Copy Markdown
Owner Author

Closed in favor of PR #2085 consolidation.

@emersonbusson
emersonbusson deleted the fix-ps1-validation-16395624662253526564 branch September 23, 2026 15:03
@google-labs-jules

Copy link
Copy Markdown

Closed in favor of PR #2085 consolidation.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementar cascata VRAM-as-swap no WSL2 (SPECv3 — Passo 3 Rust + validacao §14)

1 participant