fix: add CmdletBinding and guard clauses to Run-GuestExhaustive.ps1 - #1938
emersonbusson wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closed in favor of PR #2085 consolidation. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Summary
Adds
[Parameter(Mandatory = $false)],[ValidateSet()], and[ValidateNotNullOrEmpty()]to$VMName. Adds early guard clauses using typed exceptions to check Hyper-V module and VM existence.Commits
Details
scripts/windows/Run-GuestExhaustive.ps1Details
Verified syntax correctly validates Hyper-V module and VM existenceDetails
Low risk. Rollback if script validation behaves unexpectedly.Details
scripts/windows/Run-GuestExhaustive.ps1Details
Verified syntax correctly applies typed exceptions and ValidateSetDetails
Low risk. Rollback if script execution fails due to unknown exception types.Issue
Fixes #1
Owner
jules
Labels
type:bug,area:ps1-windows
Validation
Verified file syntax correctly applies changes.
Rollback trigger
Revert if pipeline fails downstream.
PR created automatically by Jules for task 16395624662253526564 started by @emersonbusson