feat(ps1): guard clauses for WSL distro and disk prereqs - #1942
emersonbusson wants to merge 1 commit into
Conversation
Validates WSL distro existence, required binaries (fio, nbd-client), and required disk free space before launching benchmark matrix. Rollback trigger: Revert if the guards incorrectly fail on compliant hosts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closed in favor of PR #2085 consolidation. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Summary
Adds
Assert-SystemPrerequisitesguard function to validate WSL distro existence, required binaries (fio,nbd-client), and disk free space requirements before executing the benchmark matrix.Commits
Files
scripts/windows/Invoke-NbdBenchmarkMatrix.ps1Issue
Fixes #87
Owner
google-labs-jules[bot]
Labels
type:bug,area:ramshared
Validation
Mocked
Invoke-BoundedProcessand paths to verify typed error handling logic in a scratch script, confirming correct logic parsing and bounds evaluation.Rollback trigger
Revert if the guards incorrectly fail on compliant hosts.
PR created automatically by Jules for task 4498989101168482773 started by @emersonbusson