Skip to content

🎨 Palette: Improve accessibility and transient state transitions in AppDiagnosticsView#1766

Open
emkey1 wants to merge 1 commit into
develfrom
ux-improve-diagnostics-view-3750829758085749416
Open

🎨 Palette: Improve accessibility and transient state transitions in AppDiagnosticsView#1766
emkey1 wants to merge 1 commit into
develfrom
ux-improve-diagnostics-view-3750829758085749416

Conversation

@emkey1

@emkey1 emkey1 commented Jun 16, 2026

Copy link
Copy Markdown
Owner

🎨 Palette: Improve accessibility and transient state transitions in AppDiagnosticsView

💡 What:

  • Wrapped the transient copiedReport state mutations in withAnimation blocks to provide smoother visual transitions when interacting with the "Copy Report" button.
  • Added descriptive .accessibilityLabel and .accessibilityHint modifiers to the "Close", "Copy Report", and "Run Diagnostics" buttons in the navigation toolbar, dynamically adapting the accessibility labels based on the buttons' transient states.

🎯 Why:

  • Transient feedback like a "Copied!" text popping in can feel unpolished and abrupt; wrapping these changes in standard SwiftUI transitions improves the user experience.
  • The VoiceOver experience was subpar for the toolbar buttons. Detailed accessibility hints and state-aware labels were added to clearly inform screen reader users of the specific functionalities and dynamic outcomes of their actions.

♿ Accessibility:

  • Added explicit state-aware labels to VoiceOver and dynamic hints for the AppDiagnosticsView primary actions.

PR created automatically by Jules for task 3750829758085749416 started by @emkey1

…ppDiagnosticsView

💡 What:
- Wrapped the transient `copiedReport` state mutations in `withAnimation` blocks to provide smoother visual transitions when interacting with the "Copy Report" button.
- Added descriptive `.accessibilityLabel` and `.accessibilityHint` modifiers to the "Close", "Copy Report", and "Run Diagnostics" buttons in the navigation toolbar, dynamically adapting the accessibility labels based on the buttons' transient states.

🎯 Why:
- Transient feedback like a "Copied!" text popping in can feel unpolished and abrupt; wrapping these changes in standard SwiftUI transitions improves the user experience.
- The VoiceOver experience was subpar for the toolbar buttons. Detailed accessibility hints and state-aware labels were added to clearly inform screen reader users of the specific functionalities and dynamic outcomes of their actions.

♿ Accessibility:
- Added explicit state-aware labels to VoiceOver and dynamic hints for the `AppDiagnosticsView` primary actions.

Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant