🎨 Palette: Keyboard accessory haptic and audio feedback#1767
Open
emkey1 wants to merge 4 commits into
Open
Conversation
💡 What: Implemented native keyboard click sounds for the custom terminal accessory bar, and added haptic feedback + VoiceOver announcements for the transient "Copied!" setting action. 🎯 Why: Custom accessory keys were entirely silent, breaking iOS keyboard conventions. The "Copy First Tab Values" action also provided no physical or screen-reader confirmation when successfully triggered. 📸 Before/After: N/A (non-visual interaction improvement) ♿ Accessibility: Added `UIAccessibility.post` announcements for copy operations and integrated native typing sound via `UIInputViewAudioFeedback`. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Implemented native keyboard click sounds for the custom terminal accessory bar, and added haptic feedback + VoiceOver announcements for the transient "Copied!" setting action. 🎯 Why: Custom accessory keys were entirely silent, breaking iOS keyboard conventions. The "Copy First Tab Values" action also provided no physical or screen-reader confirmation when successfully triggered. 📸 Before/After: N/A (non-visual interaction improvement) ♿ Accessibility: Added `UIAccessibility.post` announcements for copy operations and integrated native typing sound via `UIInputViewAudioFeedback`. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
💡 What: Implemented native keyboard click sounds for the custom terminal accessory bar, and added haptic feedback + VoiceOver announcements for the transient "Copied!" setting action. 🎯 Why: Custom accessory keys were entirely silent, breaking iOS keyboard conventions. The "Copy First Tab Values" action also provided no physical or screen-reader confirmation when successfully triggered. 📸 Before/After: N/A (non-visual interaction improvement) ♿ Accessibility: Added `UIAccessibility.post` announcements for copy operations and integrated native typing sound via `UIInputViewAudioFeedback`. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
💡 What: Implemented native keyboard click sounds for the custom terminal accessory bar, and added haptic feedback + VoiceOver announcements for the transient "Copied!" setting action. 🎯 Why: Custom accessory keys were entirely silent, breaking iOS keyboard conventions. The "Copy First Tab Values" action also provided no physical or screen-reader confirmation when successfully triggered. 📸 Before/After: N/A (non-visual interaction improvement) ♿ Accessibility: Added `UIAccessibility.post` announcements for copy operations and integrated native typing sound via `UIInputViewAudioFeedback`. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎨 Palette: Keyboard accessory haptic and audio feedback
💡 What: Implemented native keyboard click sounds for the custom terminal accessory bar, and added haptic feedback + VoiceOver announcements for the transient "Copied!" setting action.
🎯 Why: Custom accessory keys were entirely silent, breaking iOS keyboard conventions. The "Copy First Tab Values" action also provided no physical or screen-reader confirmation when successfully triggered.
📸 Before/After: N/A (non-visual interaction improvement)
♿ Accessibility: Added
UIAccessibility.postannouncements for copy operations and integrated native typing sound viaUIInputViewAudioFeedback.PR created automatically by Jules for task 5845473646801170323 started by @emkey1