🎨 Palette: UX improvements for copy actions#1768
Conversation
💡 What:
- Wrapped `copiedReport` and `copiedColors` transient state changes in `withAnimation {}` blocks.
- Added `UINotificationFeedbackGenerator` success haptics when copying.
- Added `UIAccessibility.post` announcements to explicitly tell screen reader users that the action succeeded.
- Added explicit `accessibilityLabel` and `accessibilityHint` to the App Diagnostics copy button.
🎯 Why:
- Actions like "Copy to Clipboard" provide no feedback on iOS for screen reader users or tactile feedback for sighted users. The state transitions were abrupt, causing a jarring visual experience. These changes soften the visual presentation while adding robust accessibility and haptic support.
♿ Accessibility:
- Users now hear a native "Report copied to clipboard" announcement.
- The button provides clear hints about its behavior via VoiceOver.
Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
- Wrapped `copiedReport` and `copiedColors` transient state changes in `withAnimation {}` blocks in `AppDiagnosticsView` and `TerminalSettingsView`.
- Added `UINotificationFeedbackGenerator` success haptics when copying.
- Added `UIAccessibility.post` announcements to explicitly tell screen reader users that the action succeeded.
- Added explicit `accessibilityLabel` and `accessibilityHint` to the App Diagnostics copy button.
🎯 Why:
- Actions like "Copy to Clipboard" provide no feedback on iOS for screen reader users or tactile feedback for sighted users. The state transitions were abrupt, causing a jarring visual experience. These changes soften the visual presentation while adding robust accessibility and haptic support.
♿ Accessibility:
- Users now hear a native "Report copied to clipboard" announcement.
- The button provides clear hints about its behavior via VoiceOver.
Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
🎨 Palette: Add animation, haptics, and VoiceOver to copy buttons
💡 What:
copiedReportandcopiedColorstransient state changes inwithAnimation {}blocks inAppDiagnosticsViewandTerminalSettingsView.UINotificationFeedbackGeneratorsuccess haptics when copying.UIAccessibility.postannouncements to explicitly tell screen reader users that the action succeeded.accessibilityLabelandaccessibilityHintto the App Diagnostics copy button.🎯 Why:
♿ Accessibility:
PR created automatically by Jules for task 9063333604521525205 started by @emkey1