🎨 Palette: Add native keyboard click sounds to terminal accessory keys#1773
🎨 Palette: Add native keyboard click sounds to terminal accessory keys#1773emkey1 wants to merge 3 commits into
Conversation
- Conform `TerminalAccessoryView` to `UIInputViewAudioFeedback` and enable `enableInputClicksWhenVisible`. - Call `UIDevice.current.playInputClick()` in `NativeTerminalView.keyTapped(_:)` to provide native audio and haptic feedback when custom accessory keys are tapped. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Conform `TerminalAccessoryView` to `UIInputViewAudioFeedback` and enable `enableInputClicksWhenVisible`. - Call `UIDevice.current.playInputClick()` in `NativeTerminalView.keyTapped(_:)` to provide native audio and haptic feedback when custom accessory keys are tapped. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
- Conform `TerminalAccessoryView` to `UIInputViewAudioFeedback` and enable `enableInputClicksWhenVisible`. - Call `UIDevice.current.playInputClick()` in `NativeTerminalView.keyTapped(_:)` to provide native audio and haptic feedback when custom accessory keys are tapped. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
💡 What: The UX enhancement added native keyboard click sounds to the custom accessory keys above the terminal keyboard.
🎯 Why: Without this, tapping the custom keys (Tab, Esc, Ctrl, etc.) felt "dead" compared to the standard iOS keyboard keys, which provide satisfying auditory and haptic feedback. This change makes the custom terminal accessory bar feel like a first-class citizen of the iOS keyboard.
📸 Before/After: Visuals unchanged, purely an auditory and haptic (on supported devices) improvement.
♿ Accessibility: Provides necessary non-visual feedback that a key was successfully pressed, benefiting all users but particularly those relying on auditory cues.
PR created automatically by Jules for task 12902152211864907260 started by @emkey1